feat(apigatewayv2): Lambda authorizer for WebSocket API #16886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tmokmss
changed the title
peterwoodworth
changed the title
github-actions
bot
added
the
@aws-cdk/aws-apigatewayv2
|
This is perfect! Exactly what I need right now. I was planning to start a PR for myself. Any chance we can prioritize this? |
Dzhuneyt
approved these changes
Oct 28, 2021
otaviomacedo
previously requested changes
Dec 14, 2021
| '$request.header.Authorization', | ||
| ], | ||
| type: WebSocketAuthorizerType.LAMBDA, | ||
| authorizerName: this.props.authorizerName, |
There was a problem hiding this comment.
Should fall back to the new id constructor arg.
| /** | ||
| * The name of the authorizer | ||
| */ | ||
| readonly authorizerName: string; |
There was a problem hiding this comment.
We need to make this API consistent with HttpLambdaAuthorizer/HttpLambdaAuthorizerProps:
- Move
handlerto the constructor ofWebSocketLambdaAuthorizer. - Pass an
idto the constructor ofWebSocketLambdaAuthorizer.
| const id = this.props.authorizerName; | ||
|
|
||
| this.webSocketApi = options.route.webSocketApi; | ||
| this.authorizer = new WebSocketAuthorizer(options.scope, id, { |
There was a problem hiding this comment.
When you add the new id constructor arg, replace id with this.id.
mergify
bot
dismissed
otaviomacedo’s stale review
Pull request has been modified.
|
@otaviomacedo |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
… `WebSocketLambdaAuthorizer` (#18315) We introduced `WebSocketLambdaAuthorizer` in #16886 with an incorrect default `identitySource`, according to these [docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigatewayv2-authorizer.html#cfn-apigatewayv2-authorizer-identitysource). The result is that using the default `identitySource` results in a deploy-time failure. This PR fixes the error and adds documentation for the syntax for all `identitySource` possibilities. I can confirm that this default successfully passes `cdk deploy` on my local app. Fixes #18307. BREAKING CHANGE: `WebSocketLambdaAuthorizerProps.identitySource` default changes from `['$request.header.Authorization']` to `['route.request.header.Authorization']`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
closes aws#13869 By this PR, you will be able to enable WebSocket authorizer as the below code: ```ts const integration = new LambdaWebSocketIntegration({ handler, }); const authorizer = new WebSocketLambdaAuthorizer('Authorizer', authHandler); new WebSocketApi(stack, 'WebSocketApi', { connectRouteOptions: { integration, authorizer, }, }); ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
… `WebSocketLambdaAuthorizer` (aws#18315) We introduced `WebSocketLambdaAuthorizer` in aws#16886 with an incorrect default `identitySource`, according to these [docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigatewayv2-authorizer.html#cfn-apigatewayv2-authorizer-identitysource). The result is that using the default `identitySource` results in a deploy-time failure. This PR fixes the error and adds documentation for the syntax for all `identitySource` possibilities. I can confirm that this default successfully passes `cdk deploy` on my local app. Fixes aws#18307. BREAKING CHANGE: `WebSocketLambdaAuthorizerProps.identitySource` default changes from `['$request.header.Authorization']` to `['route.request.header.Authorization']`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13869
By this PR, you will be able to enable WebSocket authorizer as the below code:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license